Skip write op in read only #6550
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
PR Overview
This PR adds a new decorator (@skip_if_read_only_mode) to the _rebuild_kb_chunk task to prevent write operations during read-only operations.
- Adds the @skip_if_read_only_mode decorator to the _rebuild_kb_chunk task.
- Helps avoid transaction errors during document deletion.
Reviewed Changes
| File | Description |
|---|---|
| kitsune/wiki/tasks.py | Added @skip_if_read_only_mode decorator to skip task execution in read-only mode |
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
akatsoulas
reviewed
Mar 11, 2025
kitsune/wiki/tasks.py
Outdated
| @@ -214,6 +214,7 @@ def rebuild_kb(): | |||
|
|
|||
|
|
|||
| @shared_task(rate_limit="5/m") | |||
| @skip_if_read_only_mode | |||
There was a problem hiding this comment.
this is called by rebuild_kb task which already has the decorator. Maybe that's not the cause of the sentry error?
There was a problem hiding this comment.
Thanks - sorry, I had pulled this back into In Progress status for this very reason. Revision added.
akatsoulas
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
@skip_if_read_only_modeto_rebuild_kb_chunktaskPrevents task from executing during read-only operations like document deletion,
avoiding transaction errors.